Nir Soffer has posted comments on this change. Change subject: v2v: cleanup v2v directory leftovers ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/39789/7/vdsm/clientIF.py File vdsm/clientIF.py: Line 107: self.channelListener.start() Line 108: self.threadLocal = threading.local() Line 109: self.threadLocal.client = '' Line 110: Line 111: v2v.clean_leftovers() > this can be taken before irs initialization, to avoid making the try-block irs is initialized in vdsm script - do you suggest to do this in vdsm before creating irs? Line 112: Line 113: host = config.get('addresses', 'management_ip') Line 114: port = config.getint('addresses', 'management_port') Line 115: self._createAcceptor(host, port) -- To view, visit https://gerrit.ovirt.org/39789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f5b63863f4f7dc85d6af0ca015099274715441 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
