Piotr Kliczewski has posted comments on this change. Change subject: stomp: add an option to create a stomp client ......................................................................
Patch Set 5: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/38491/5/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 203: for handler in self._handlers: Line 204: if handler.NAME == "stomp": Line 205: return handler.createClient(connected_socket) Line 206: Line 207: return None > i'd raise exception here - NotImplemented It is not about being not implemented. We can have implementation but it can be disabled in config.py. I agree with raising an exception but different one. Line 208: Line 209: Line 210: class _CannotDetectProtocol(Exception): Line 211: pass -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Bronheim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
