Martin Polednik has posted comments on this change. Change subject: draft: unittests for sriov domxml example ......................................................................
Patch Set 1: (1 comment) Also the test does possibly not catch it, please wait for update. https://gerrit.ovirt.org/#/c/40049/1/tests/devices/parsing/complex_vm_tests.py File tests/devices/parsing/complex_vm_tests.py: Line 16: Line 17: devices = [ Line 18: {'device': 'spice', 'type': 'graphics'}, Line 19: {'device': 'pci_0000_02_11_0', 'specParams': {'macAddr': '00:1a:4a:16:01:59'}, 'type': 'hostdev', Line 20: 'alias': 'test'}] Don't specify the alias in specification: it should be correctly recognized by getUnderlying* family of functions. Line 21: Line 22: test_path = os.path.realpath(__file__) Line 23: dir_name = os.path.split(test_path)[0] Line 24: api_path = os.path.join( -- To view, visit https://gerrit.ovirt.org/40049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia573d19e381331ec4a306f2811f9ef6359b02f36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
