Dan Kenigsberg has posted comments on this change. Change subject: virt: stats: periodic sampling using bulk stats ......................................................................
Patch Set 59: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/36722/59/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 563: self._log.exception("vm sampling failed") Line 564: else: Line 565: self._stats_cache.put(_translate(bulk_stats), timestamp) Line 566: finally: Line 567: self._sampling = False this is raceful: please replace with a Semaphore Line 568: Line 569: def _get_responsive_doms(self): Line 570: vms = self._get_vms() Line 571: doms = [] -- To view, visit https://gerrit.ovirt.org/36722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 59 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
