Dan Kenigsberg has posted comments on this change.
Change subject: virt: stats: drop {Advanced,Vm}StatsThread
......................................................................
Patch Set 19: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/39284/19/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 238:
Line 239: self._enabled = False
Line 240: self.channelListener.stop()
Line 241: self._hostStats.stop()
Line 242: # periodic operations stopped outside
no need to comment on non-existing code!
Line 243: if self.mom:
Line 244: self.mom.stop()
Line 245: if self.irs:
Line 246: return self.irs.prepareForShutdown()
https://gerrit.ovirt.org/#/c/39284/19/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 284
Line 285
Line 286
Line 287
Line 288
I like this side affect, of keeping stats-collection suring migration, as long
as libvirt supports it.
https://gerrit.ovirt.org/#/c/39284/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1595
Line 1596
Line 1597
Line 1598
Line 1599
self._guestEventTime mast be set to time() on vm domDependent or else we would
never report POWERING_UP.
--
To view, visit https://gerrit.ovirt.org/39284
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia724c94867f470d32f063a1b177e73d2382e6525
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
