Michal Skrivanek has posted comments on this change. Change subject: events: sending stats with vm status change event ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Vinzenz, Francesco, please help with getting the right content to send. Each omitted field should be checked against latest engine monitoring code https://gerrit.ovirt.org/#/c/40204/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 785: Line 786: def _send_status_event(self, value): Line 787: self.cif.notify('|virt|VM_status|' + self.id, Line 788: **{self.id: {'status': value, Line 789: 'stats': self.getStats()}}) I think we should rather assemble our own set of data instead generic getStats(). We clearly do not need applist (potentially huge), and quite likely other things. I'd start with minimum and check the engine side what's really needed. Our advantage is that we can consider only 3.6 engine, many legacy fields can be dropped Line 790: Line 791: lastStatus = property(_get_lastStatus, _set_lastStatus) Line 792: Line 793: def __getNextIndex(self, used): -- To view, visit https://gerrit.ovirt.org/40204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a1bdea997ec24342bbb25b3baeb3e7f8313321 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
