Yaniv Bronhaim has posted comments on this change. Change subject: utils: Add systemd_run command modifier ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/40239/1/configure.ac File configure.ac: Line 327: AC_PATH_PROG([SUDO_PATH], [sudo], [/usr/bin/sudo]) Line 328: AC_PATH_PROG([SU_PATH], [su], [/bin/su]) Line 329: AC_PATH_PROG([SYSCTL_PATH], [sysctl], [/sbin/sysctl]) Line 330: AC_PATH_PROG([SYSTEMCTL_PATH], [systemctl], [/bin/systemctl]) Line 331: AC_PATH_PROG([SYSTEMD_RUN_PATH], [systemd-run], [/usr/bin/systemd-run]) if only one place uses it - define it there with CommandPath Line 332: AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar]) Line 333: AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc]) Line 334: AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) Line 335: AC_PATH_PROG([TOUCH_PATH], [touch], [/bin/touch]) https://gerrit.ovirt.org/#/c/40239/1/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: Line 52: command.extend(cmd) Line 53: return command Line 54: Line 55: Line 56: def systemd_run(cmd, scope=False, unit=None, slice=None): this is specific code for systemd - shouldn't be in vdsm core. either have verb in vdsm-tool for that and call it or have specific systemd code under init/systemd folder. Line 57: command = [constants.EXT_SYSTEMD_RUN] Line 58: if scope: Line 59: command.append('--scope') Line 60: if unit: https://gerrit.ovirt.org/#/c/40239/1/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 12: @MV_PATH@ /etc/multipath.conf *, \ Line 13: @CP_PATH@ * /etc/iscsi/iscsid.conf, \ Line 14: @SERVICE_PATH@ iscsid *, \ Line 15: @BINDIR@/vdsm-tool service-restart multipathd, \ Line 16: @BINDIR@/vdsm-tool service-reload multipathd, \ if adding any permission I would add vdsm-tool call for it which hides the specific implementation ^ Line 17: @ISCSIADM_PATH@ *, \ Line 18: @LVM_PATH@, \ Line 19: @CAT_PATH@ /sys/block/*/device/../../*, \ Line 20: @CAT_PATH@ /sys/devices/platform/host*, \ -- To view, visit https://gerrit.ovirt.org/40239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35bdae752228b6716c25f0b9975fc500897a592 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
