Dan Kenigsberg has posted comments on this change. Change subject: Move passwd (set saslpassword for libvirt) to vdsm-tool ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39823/5/lib/vdsm/tool/configurators/passwd.py File lib/vdsm/tool/configurators/passwd.py: Line 46: return NO Line 47: Line 48: Line 49: def configure(): Line 50: script = (str(_SASLPASSWD2), '-p', '-a', 'libvirt', SASL_USERNAME) _SASLPASSWD2.cmd returns a string. If it does not - we have a big problem everywhere. Line 51: rc, _, err = utils.execCmd(script, data=libvirt_password()) Line 52: if rc != 0: Line 53: raise RuntimeError("Set password failed: %s" % (err,)) Line 54: -- To view, visit https://gerrit.ovirt.org/39823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98583500a43f35a04ec258f43c0329e71da575c8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
