Francesco Romani has posted comments on this change. Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39203/4/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 44: Line 45: def _callMethod(self, methodName, *args): Line 46: try: Line 47: method = command_converter[methodName] Line 48: except AttributeError as e: > somebody can try to use jsonrpcvdscli for a method that has not yet been de ok, but being command_converter a dict, I'd expect a KeyError here. Why AttributeError? Line 49: raise InvalidCall(methodName, args, e) Line 50: Line 51: req = JsonRpcRequest(method, args, reqId=str(uuid4())) Line 52: call = self._client.call_async(req) -- To view, visit https://gerrit.ovirt.org/39203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
