Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40088/1/vdsm/network/api.py File vdsm/network/api.py: Line 558: os.makedirs(dir_path) Line 559: except OSError as ose: Line 560: if errno.EEXIST != ose.errno: Line 561: raise Line 562: with open(dir_path, device_name, 'w') as f: > os.path.join Done Line 563: f.write(str(numvfs)) Line 564: Line 565: Line 566: def changeNumvfs(device_name, num_vfs): https://gerrit.ovirt.org/#/c/40088/1/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 67: return num_vfs_by_device, missing_devices Line 68: Line 69: Line 70: def _remove_missing_devices_persistence(missing_devices): Line 71: for file_name in missing_devices: > please log missing devices - if we suddenly no longer see a device, let the Done Line 72: os.remove(os.path.join(_VIRTUAL_FUNCTIONS_PATH, file_name)) Line 73: Line 74: Line 75: def _restore_sriov_num_vfs(): -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
