Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Remove leftover libvirtd.log rotating logic. ......................................................................
tool: Remove leftover libvirtd.log rotating logic. Vdsm libvirt logging definitions were recently dropped in favor of libvirt defaults[1]. It is now up to libvirt to manage logging, rotating included. libvirt.logrotate is a file installed by libvirt's rpm and then modified by vdsm-tool. we need to stop modifying it, and drop modifications when libvirtd.conf updates to include [1] - When we have a version bump. [1] http://gerrit.ovirt.org/#/q/I251c2534d3284aa95bffa56143c449d5de887008,n,z Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149757 Signed-off-by: Mooli Tayer <mta...@redhat.com> Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/33925 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M debian/vdsm.install M lib/vdsm/tool/Makefile.am M lib/vdsm/tool/configurators/libvirt.py D lib/vdsm/tool/libvirtd.logrotate M tests/Makefile.am M tests/toolTests.py D tests/toolTests_libvirt_logrotate.conf M vdsm.spec.in M vdsm/Makefile.am D vdsm/vdsm-libvirt-logrotate 10 files changed, 0 insertions(+), 102 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches