Nir Soffer has posted comments on this change. Change subject: sslutils: move createSSLContext from clientIF ......................................................................
Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/36699/5/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 338: if not self._is_handshaking: Line 339: self._handshake_finished_handler(dispatcher) Line 340: Line 341: Line 342: def ssl_enabled(): > considering the module name, the 'ssl_' prefix is perhaps a bit redundant, This was true if the module was called ssl (ssl.enabled()), but sslutils.enabled() does not make much sense. Line 343: return config.getboolean('vars', 'ssl') Line 344: Line 345: Line 346: def create_ssl_context(): -- To view, visit https://gerrit.ovirt.org/36699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
