Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: fix call to super ctor ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39781/4/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 29: _STATE_ONESHOT = 4 Line 30: Line 31: Line 32: class JsonRpcError(RuntimeError): Line 33: def __init__(self, code, msg): I think we should avoid overriding __init__ altogather and implement this in __str__ instead: def __str__(self): return '%s: [%d] %s' % (self.__class__.__name__, self.args[0], self.args[1]) Line 34: super(JsonRpcError, self).__init__( Line 35: "[%d] %s" % (code, msg) Line 36: ) Line 37: -- To view, visit https://gerrit.ovirt.org/39781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
