Francesco Romani has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage ......................................................................
Patch Set 2: Code-Review+1 (1 comment) only a minor style nit inside https://gerrit.ovirt.org/#/c/40127/2/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 29: from .core import Base Line 30: Line 31: DEFAULT_INTERFACE_FOR_ARCH = {caps.Architecture.X86_64: 'ide', Line 32: caps.Architecture.PPC64: 'scsi', Line 33: caps.Architecture.PPC64LE: 'scsi'} slightly better: DEFAULT_INTERFACE_FOR_ARCH = { caps.Architecture.X86_64: 'ide', caps.Architecture.PPC64: 'scsi', caps.Architecture.PPC64LE: 'scsi' } easier to add/remove new key/values pairs. But not that important. Line 34: Line 35: Line 36: class DRIVE_SHARED_TYPE: Line 37: NONE = "none" -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
