Bala.FA has posted comments on this change. Change subject: gluster: Adds a new element 'extraFeaturesSupported' to getVdsCaps. ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/39324/2/vdsm/caps.py File vdsm/caps.py: Line 712: extraFeaturesSupported 1. How about 'additionalFeatures' than 'extraFeaturesSupported'? 2. Is it good idea to list features (like GLUSTER_BRICK_MANAGEMENT etc) than feature group name 'GLUSTER_37_FEATURES'? -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
