Francesco Romani has uploaded a new change for review. Change subject: virt: rename SampleVMs for clarity ......................................................................
virt: rename SampleVMs for clarity SampleVMs is a bad name. Change it to VMBulkSampler, which is a bit more explicative. No changes in logic, only renaming. Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Signed-off-by: Francesco Romani <[email protected]> --- M vdsm/virt/periodic.py M vdsm/virt/sampling.py 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/40370/1 diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py index 8c79d71..33efe16 100644 --- a/vdsm/virt/periodic.py +++ b/vdsm/virt/periodic.py @@ -87,10 +87,10 @@ config.getint('vars', 'vm_sample_jobs_interval')), # libvirt sampling using bulk stats can block, but unresponsive - # domains are handled inside SampleVMs for performance reasons; + # domains are handled inside VMBulkSampler for performance reasons; # thus, does not need dispatching. Operation( - sampling.SampleVMs( + sampling.VMBulkSampler( libvirtconnection.get(cif), cif.getVMs, sampling.stats_cache), diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py index 5a205f7..6804406 100644 --- a/vdsm/virt/sampling.py +++ b/vdsm/virt/sampling.py @@ -491,7 +491,7 @@ _TIMEOUT = 40.0 -class SampleVMs(object): +class VMBulkSampler(object): def __init__(self, conn, get_vms, stats_cache, stats_flags=0, timeout=_TIMEOUT): self._conn = conn @@ -500,7 +500,7 @@ self._stats_flags = stats_flags self._skip_doms = ExpiringCache(timeout) self._sampling = Stage() - self._log = logging.getLogger("sampling.SampleVMs") + self._log = logging.getLogger("sampling.VMBulkSampler") def __call__(self): timestamp = self._stats_cache.clock() -- To view, visit https://gerrit.ovirt.org/40370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
