Francesco Romani has uploaded a new change for review.
Change subject: sampling: more detailed stale sampling reporting
......................................................................
sampling: more detailed stale sampling reporting
To improve troubleshooting, report timestamps
of current and stale samples when discarding
data for timestamp too old.
We are already logging this event, so adding new
information is quite cheap and can make
troubleshooting easier.
Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91
Signed-off-by: Francesco Romani <from...@redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/40390/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 6804406..7d7596e 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -464,13 +464,16 @@
with stale one.
"""
with self._lock:
- if monotonic_ts >= self._last_sample_time:
+ last_sample_time = self._last_sample_time
+ if monotonic_ts >= last_sample_time:
self._samples.append(bulk_stats)
self._last_sample_time = monotonic_ts
self._update_ts(bulk_stats, monotonic_ts)
else:
- self._log.warning('dropped stale old sample')
+ self._log.warning(
+ 'dropped stale old sample: sampled %f stored %f',
+ monotonic_ts, last_sample_time)
def _update_ts(self, bulk_stats, monotonic_ts):
# FIXME: this is expected to be costly performance-wise.
--
To view, visit https://gerrit.ovirt.org/40390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
