Ido Barkan has posted comments on this change. Change subject: Move udevadm to lib/vdsm ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py File tests/samplingTests.py: Line 149: s1 = sampling.InterfaceSample(lo) Line 150: s1.operstate = 'x' Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0)) Line 152: Line 153: #@brokentest("Broken unless libvirtd is running") > this is a real pep8 error. add a space after the #. slippery fingers. Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password) Line 155: @ValidateRunningAsRoot Line 156: def testHostSampleReportsNewInterface(self): Line 157: hs_before = sampling.HostSample(os.getpid()) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
