Martin Polednik has posted comments on this change.

Change subject: network: restore sriov devices number of vfs
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/40088/6/vdsm/network/api.py
File vdsm/network/api.py:

Line 562:     """
Line 563:     logger = logging.getLogger("changeNumvfs")
Line 564:     original_value = _get_num_vfs(device_name)
Line 565:     logger.info("changing number of vfs on device %s to %s.",
Line 566:                 device_name, num_vfs)
> Not sure I understand. Do you mean using _SYSFS_SRIOV_NUMVFS.format(device_
Meant 'changing number of vfs on device {} to {}'.format(device_name, num_vfs)
Line 567:     _update_num_vfs(device_name, num_vfs)
Line 568:     if not clientSeen(CONNECTIVITY_TIMEOUT_DEFAULT):
Line 569:         _update_num_vfs(device_name, original_value)
Line 570:         logger.error("changing number of vfs on device %s failed 
during "


-- 
To view, visit https://gerrit.ovirt.org/40088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to