Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: add unit test for getUnderlying* family of methods ......................................................................
virt: add unit test for getUnderlying* family of methods Our tests did not cover the process of retrieving device information from libvirt XML. This patch is a first step to add such coverage on the side of unit tests. Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0 Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: https://gerrit.ovirt.org/39364 Reviewed-by: Ido Barkan <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M configure.ac M debian/vdsm-tests.install M tests/Makefile.am A tests/devices/Makefile.am A tests/devices/__init__.py A tests/devices/data/Makefile.am A tests/devices/data/testComplexVm.xml A tests/devices/parsing/Makefile.am A tests/devices/parsing/__init__.py A tests/devices/parsing/complex_vm_tests.py M tests/vmfakelib.py M vdsm.spec.in 12 files changed, 311 insertions(+), 3 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/39364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
