Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Improve error handling in diskReplicateStart ......................................................................
vm: Improve error handling in diskReplicateStart Move the call to Vm._setDiskReplica() just before the try block ensuring that this is operation is reverted on errors. Previously there were some lines before the try block, and an exception raised in these lines would leave the disk in replication state. Change-Id: I7b69f5be29483d174dd296feaf5970c58c13a347 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40021 Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Adam Litke <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b69f5be29483d174dd296feaf5970c58c13a347 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
