Piotr Kliczewski has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39969/4/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 406: return int(round(monotonic_time() * 1000)) Line 407: Line 408: def handle_close(self, dispatcher): Line 409: dispatcher.close() Line 410: self.connection.clean() > Why don't you call connection.close instead of clean? good idea. connection.close() already calls both method. Line 411: Line 412: Line 413: class AsyncClient(object): Line 414: log = logging.getLogger("yajsonrpc.stomp.AsyncClient") -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
