Ido Barkan has posted comments on this change. Change subject: network: restore sriov devices number of vfs ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40088/7/vdsm/network/api.py File vdsm/network/api.py: Line 550: with open(os.path.join(dir_path, device_name), 'w') as f: Line 551: f.write(str(numvfs)) Line 552: Line 553: Line 554: def changeNumvfs(device_name, num_vfs): > 'numvfs' is the name used everywhere in kernel and documentation, I don't s okay. Line 555: """Change number of virtual functions of a device in a 'safe' way. If the Line 556: connectivity to engine is lost as a consequence, the value is restored. Line 557: Since calling this verb is currently blocked by engine if this device is Line 558: already in use, the logic does not attempt to do anything further, such as -- To view, visit https://gerrit.ovirt.org/40088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b898019840ffe65939ffad4a1e98829ad3c887 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
