Nir Soffer has posted comments on this change. Change subject: storage: Factor out getAllVolumes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40377/1/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 415: imgUUID = os.path.basename(head) Line 416: try: Line 417: images[imgUUID].append(volUUID) Line 418: except KeyError: Line 419: images[imgUUID] = [volUUID] Why did you replace defaultdict with regular dict? Line 420: return images Line 421: Line 422: def getAllVolumes(self): Line 423: """ -- To view, visit https://gerrit.ovirt.org/40377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c55edf6416dddc4a4f30b91422b3e968df2b99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
