Nir Soffer has posted comments on this change. Change subject: v2v: Add convertExternalVm for XmlRpc ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40003/4/client/vdsClient.py File client/vdsClient.py: Line 1921: def convertExternalVm(self, args): Line 1922: validateArgTypes(args, [str, str, str, parse_dict, str], Line 1923: requiredArgsNumber=5) Line 1924: uri, username, auth, vminfo, jobid = args Line 1925: passwd = parsePassword(auth) > Instead of adding new confusing parsePassword function, you can use the exi Bug parseArgs except a list not a string - so: d = parseArgs([auth]) password = getAuthFromArgs(d, auth) Line 1926: response = self.s.convertExternalVm(uri, username, passwd, vminfo, Line 1927: jobid) Line 1928: if response['status']['code'] != 0: Line 1929: return response['status']['code'], response['status']['message'] -- To view, visit https://gerrit.ovirt.org/40003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94d7886e1295f5e98d0fafc8837567ff383a6c7a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
