Nir Soffer has posted comments on this change. Change subject: hsm: Call for resize_if_needed in getDeviceList ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40469/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2040 Line 2041 Line 2042 Line 2043 Line 2044 The resize should be part of pathListIter. You will have to move the typeFilter down to it, so it handle only device of certain type. Line 2039: else: Line 2040: for pv in lvm.getAllPVs(): Line 2041: pvs[os.path.basename(pv.name)] = pv Line 2042: Line 2043: multipath.resize_devices_if_needed(guids) You are ignoring the typeFilter - the user asked to get iSCSI devices and you resize FC devices. Line 2044: Line 2045: # FIXME: pathListIter() should not return empty records Line 2046: for dev in multipath.pathListIter(guids): Line 2047: if not typeFilter(dev): -- To view, visit https://gerrit.ovirt.org/40469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b1b699b1a905e949e98f435f339a21dad640c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
