Martin Polednik has posted comments on this change. Change subject: network: wait for udev after configuring SRIOV ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py File vdsm/network/api.py: Line 536: # that are not yet named by udev or not report all of. This is a blocking Line 537: # call that should wait for all udev events to be handled. a proper fix Line 538: # should be registering and listening to the proper netlink and udev Line 539: # events Line 540: time.sleep(0.5) This might be a bit too ugly :( Is the sleep really needed? What is it's purpose? Line 541: udevadm.settle(timeout=10) Line 542: Line 543: Line 544: def _update_numvfs(device_name, numvfs): -- To view, visit https://gerrit.ovirt.org/40400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04d63ca35aab585051c3d0a5f2652dbf2f91b080 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
