Nir Soffer has posted comments on this change. Change subject: ceph: Validate network disk parameters ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40477/2/tests/vmStorageTests.py File tests/vmStorageTests.py: Line 230: Line 231: def test_network_disk_no_hosts(self): Line 232: self.check(diskType=DISK_TYPE.NETWORK, protocol='rbd') Line 233: Line 234: def test_network_disk_no_hosts(self): > duplicated name Thanks Francesco! Copy and paste is evil :-) Line 235: self.check(diskType=DISK_TYPE.NETWORK, hosts=[{}]) Line 236: Line 237: def check(self, **kw): Line 238: conf = drive_config(**kw) -- To view, visit https://gerrit.ovirt.org/40477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
