Francesco Romani has uploaded a new change for review. Change subject: virt: do not use status after getStat() ......................................................................
virt: do not use status after getStat() the getStat() method already provide an up to date status of the migration.SourceThread. It was used because of its side effect to update the internal status, but its return value provides the very same information of a direct access to the status field, and also reduces the coupling. Change-Id: I2f1d330376590d0c4060baa9b13e5496c8b7f9ee Signed-off-by: Francesco Romani <from...@redhat.com> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/40522/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index d0d116c..36a6853 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1460,8 +1460,7 @@ self._migrationSourceThread = migration.SourceThread( self, **params) self._migrationSourceThread.start() - self._migrationSourceThread.getStat() - return self._migrationSourceThread.status + return self._migrationSourceThread.getStat() finally: self._guestCpuLock.release() -- To view, visit https://gerrit.ovirt.org/40522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f1d330376590d0c4060baa9b13e5496c8b7f9ee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches