Dan Kenigsberg has submitted this change and it was merged.

Change subject: periodic: improve isolation in VM dispatching
......................................................................


periodic: improve isolation in VM dispatching

Make VmDispatcher more robust:

1. add try/except block inside the vm dispatching loop, to make sure
that one exception doesn't prevent further dispatching.
This may happen if for any reason runnable() or required() raise.

2. catch exceptions to make sure to log vm id, to make troubleshooting
easier.

3. add tests to check the that dispatching continues in presence
of exceptions inside the VmDispatcher loops (#1 above)

Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7
Signed-off-by: Francesco Romani <from...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40339
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M tests/periodicTests.py
M vdsm/virt/periodic.py
2 files changed, 62 insertions(+), 23 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/40339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to