Dan Kenigsberg has submitted this change and it was merged. Change subject: network: no need to log when network persistence path doesn't exist. ......................................................................
network: no need to log when network persistence path doesn't exist. When RunningConfig is instantiated, its underlying directory structure may not exist. This is perfectly OK on the start-up of a process. We prefer dropping the messages over having __init__ with side effects on the file system. The dropped messages were contaminating supervdsm.log and are a source of confusion and red herrings. Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Signed-off-by: Ido Barkan <ibar...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/40415 Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/netconfpersistence.py 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Ido Barkan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f998b5ec7a5d0d07e35afdcc9a9d76b42b3c6a0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches