Nir Soffer has posted comments on this change. Change subject: python3: avoid python3-inconsistent syntax ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40215/3/Makefile.am File Makefile.am: Line 134: if [ -x "$(PYTHON3)" ]; \ Line 135: then \ Line 136: $(PYTHON3) -m compileall `find . -name '*.py' -o -name '*.py.in'`; \ Line 137: else \ Line 138: echo "Warning: skipping python3 syntax check"; \ > I don't want to hard-build-require the existence of Python 3 as of yet. It I agree, just remove the "Warning:" prefix. It is ok to build vdsm when python 3 is not installed, nothing to warn about. Line 139: fi Line 140: Line 141: # Note: dependencies ordered by time needed to run them Line 142: check-recursive: gitignore python3 pyflakes pep8 -- To view, visit https://gerrit.ovirt.org/40215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aff56a7e213adf469ceabb0e3cf47ef3e69cc1a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
