Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Extract Drive.diskType property ......................................................................
virt: Extract Drive.diskType property This is the first step in breaking getXML() to separate methods for rendering individual elements, required to create replica disk xml without code duplication. The diskType property is also required for Ceph support, where it will be sent from the engine. This property helps the rest of the code to work in the same way if diskType was sent from the engine (new engine) or deduced from blockDev and networkDev properties (old engine). Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/40062 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/virt/vmdevices/storage.py 1 file changed, 24 insertions(+), 9 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec13ca58ee4f3db919198bdeae781473a97e072d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
