Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Set source attributes consistently ......................................................................
virt: Set source attributes consistently For "block" and "network" we were using source.setAttrs(key=value), but for file we were using less clear source.setAttrs(**dict). Change-Id: I4bcc3846428c7f2cc14cf19254617378b668404a Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/40064 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/virt/vmdevices/storage.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bcc3846428c7f2cc14cf19254617378b668404a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches