Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Extract helpers for major XML elements ......................................................................
virt: Extract helpers for major XML elements Now drive xml is built using small helper methods creating each of the elements. This is more maintainable and will allow creating drive replica xml without code duplication. Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/40066 Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/virt/vmdevices/storage.py 1 file changed, 61 insertions(+), 48 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef6a38d3abc14413f1001a8673f38fce8d828b7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
