Nir Soffer has posted comments on this change.

Change subject: storageServer: Run glusterfs in its own cgroup
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40240/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 274:         #      - 22180 /usr/bin/glusterfs ...
Line 275:         #    - run-21649.scope
Line 276:         #      - 21692 /usr/bin/glusterfs ...
Line 277:         #
Line 278:         modifier = partial(cmdutils.systemd_run, scope=True, 
slice='glusterfs')
> Add this knowledge somewhere (bug on systemd if any, etc.)
I will open a cgexec/systemd bug, was busy in getting this work.

I'm not very happy with the modifier thing, this was attempt to make smallest 
change to fix this issue.

I will explore a nicer way to do this in the next version.
Line 279:         MountConnection.connect(self, modifier=modifier)
Line 280: 
Line 281: 
Line 282: class NFSConnection(object):


-- 
To view, visit https://gerrit.ovirt.org/40240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79714a9a6ecbde17c396eca6b17b9e3605fad688
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to