Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs ......................................................................
Patch Set 18: Code-Review-1 (1 comment) very partial review... https://gerrit.ovirt.org/#/c/40312/18/vdsm_hooks/ovs/ovs_before_device_create.py File vdsm_hooks/ovs/ovs_before_device_create.py: Line 52: ovs_device(domxml) Line 53: Line 54: for iface in domxml.getElementsByTagName('interface'): Line 55: source = iface.getElementsByTagName('source')[0] Line 56: source_bridge = source.getAttribute('bridge') Engine would never pass BRIDGE_NAME here, but the specific network it wants to have this vnic connected to. You should replace the source_bridge with BRIDGE_NAME, and add the vlan tag if needed. Line 57: if source_bridge == BRIDGE_NAME: Line 58: virtualport = iface.createElement('virtualport') Line 59: assert virtualport == 'openvswitch' Line 60: -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
