Yaniv Bronhaim has posted comments on this change. Change subject: spec: Drop el6 support ......................................................................
Patch Set 5: (6 comments) https://gerrit.ovirt.org/#/c/40419/5/vdsm.spec.in File vdsm.spec.in: Line 786 Line 787 Line 788 Line 789 Line 790 I guess we don't need this vdsm-reg.init as well Line 934 Line 935 Line 936 Line 937 Line 938 don't we need this exit 0 ? Line 971 Line 972 Line 973 Line 974 Line 975 all this section should be removed in different patch Line 1012 Line 1013 Line 1014 Line 1015 Line 1016 same Line 1031 Line 1032 Line 1033 Line 1034 Line 1035 same Line 53: %if ! 0%{?rhel} || ! 0%{fedora_koji_build} Line 54: %global with_vhostmd 1 Line 55: %endif Line 56: Line 57: %global with_chown_hack 1 you can always enable it now and remove the global Line 58: Line 59: %global _udevrulesdir /usr/lib/udev/rules.d/ Line 60: %global _udevexecdir /usr/lib/udev/ Line 61: -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
