Sandro Bonazzola has posted comments on this change. Change subject: Revert "clusterLock: Make inquire retval consistent" ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40652/3/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py: Line 464: Line 465: def inquire(self): Line 466: with self._globalLockMapSync: Line 467: hostId, lockFile = self._getLease() Line 468: return self.LVER, hostId if lockFile else None > Please let's make this explicit with: pep8 allows it, it's the recomended way to write that code. Line 469: Line 470: def release(self): Line 471: with self._globalLockMapSync: Line 472: self.log.info("Releasing local lock for domain %s", self._sdUUID) -- To view, visit https://gerrit.ovirt.org/40652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21611beaeb430c04ff5678189733d54cb1df6a84 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
