Nir Soffer has posted comments on this change. Change subject: vm: Add required information to replica dict ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/40024/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3051: Line 3052: replica['device'] = 'disk' Line 3053: replica['format'] = 'cow' Line 3054: replica.setdefault('cache', drive.cache) Line 3055: replica.setdefault('propagateErrors', drive.propagateErrors) > drive.propagateErrors could be missing from drive (AttributeError). @propagateErrors is required property according to the schema, and Drive._getDriverXML will blow up if its missing. This property is also normalized in getConfDrives. If engine is sending bad value, this is engine responsibility. We do not validate input from engine yet. I will check that engine sent this value since 3.3. Line 3056: Line 3057: # First mark the disk as replicated, so if we crash after the volume is Line 3058: # prepared, we clean up properly in diskReplicateFinish. Line 3059: try: -- To view, visit https://gerrit.ovirt.org/40024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If28c9e6d084fd27857ff9da2c024d8798f375cbd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
