Nir Soffer has posted comments on this change.

Change subject: Removing flag for disabling chown hack in el6
......................................................................


Patch Set 1:

(2 comments)

Please rebase on top of https://gerrit.ovirt.org/39310, or remove only the 
configure and spec stuff, and leave the logic in the template as is.

I have done significant work on this module, and I don't want to rebase and 
re-check these patches.

I'm not worried about the rhel6 support code, we can carry it until these 
patches are merged.

https://gerrit.ovirt.org/#/c/40711/1/vdsm/storage/vdsm_lvm_rules.template.in
File vdsm/storage/vdsm_lvm_rules.template.in:

Line 51
Line 52
Line 53
Line 54
Line 55
Since we don't need now two writes, we should merge the writes to one write.


Line 52
Line 53
Line 54
Line 55
Line 56
This empty line is here on purpose.


-- 
To view, visit https://gerrit.ovirt.org/40711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea9e772e3facae12b6cc48e97d3cf157a2f32a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to