Darshan N has posted comments on this change.

Change subject: gluster: revamp in geo-replication status and list verbs.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39910/2/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1143:                               checkpointTime: 'checkpoint set time'
Line 1144:                               checkpointCompletionTime: 'checkpoint 
completion
Line 1145:                                                          time'
Line 1146:                               checkpointCompleted: 'yes/no'}]...
Line 1147:                ]....
> This vdsm verb is not released yet, so do we need backward compatibility?
Yes, Sahina is right. Since this verb was recently added and its not in any 
release, This should no be a concern.
Line 1148:     }
Line 1149:     """
Line 1150:     status = {}
Line 1151:     for volume in tree.findall('geoRep/volume'):


-- 
To view, visit https://gerrit.ovirt.org/39910
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9405e936b69e9dd4d2ed6621cfc1c70752def26
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to