Darshan N has posted comments on this change. Change subject: gluster: New verb to mount & update fstab for meta-volume ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40497/2/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 165: @makePublic Line 166: def mountMetaVolume(device): Line 167: if not os.path.exists(META_VOL_MOUNT_POINT): Line 168: try: Line 169: os.makedirs(META_VOL_MOUNT_POINT, 0o755) > Why 0o755 ? Any specific reason? This is new style octal literal. In vdsm this type of literal is being used since patch: https://gerrit.ovirt.org/#/c/40211/, which would be helpful for python 2 to 3 migration Line 170: except OSError: Line 171: raise ge.GlusterMetaVolumeMountFailedException( Line 172: err=['Mount Point creation failed']) Line 173: -- To view, visit https://gerrit.ovirt.org/40497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d109a5de9374f21b1b94f73187b653c121a8b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
