Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40712/6/lib/vdsm/define.py File lib/vdsm/define.py: Line 149: 'message': 'Failed to update ioTune values'}}, Line 150: 'V2VConnection': {'status': { Line 151: 'code': 65, Line 152: 'message': 'error connecting to hypervisor'}}, Line 153: 'secretBadRequestErr': {'status': { I think we need one error for all verbs for bad request. The caller can customize the error message so the client can see useful info about the error. Line 154: 'code': 66, Line 155: 'message': 'Bad secret request'}}, Line 156: 'secretRegisterErr': {'status': { Line 157: 'code': 67, -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
