Piotr Kliczewski has posted comments on this change. Change subject: stomp: add an option to create a stomp client ......................................................................
Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38491/7/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 441: def __init__(self, json_binding): Line 442: self.json_binding = json_binding Line 443: self._reactor = self.json_binding.reactor Line 444: Line 445: def createClient(self, connected_socket): It is better to have this code in clientIF not here. This class is responsible for something else and as Nir is suggesting it should not be involved in client creation. Line 446: return self._reactor.createClient(connected_socket) Line 447: Line 448: def detect(self, data): Line 449: return data.startswith(stomp.COMMANDS) -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
