Francesco Romani has posted comments on this change. Change subject: Getting migration statistics NPE ......................................................................
Patch Set 2: (2 comments) Ok for me, but commit message fixes were lost... https://gerrit.ovirt.org/#/c/40657/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-07 14:18:18 +0300 Line 4: Commit: Shahar Havivi <[email protected]> Line 5: CommitDate: 2015-05-11 11:24:15 +0300 Line 6: Line 7: Getting migration statistics NPE let's replace the summary line with vm: prevent KeyError in migrateStatus Line 8: Line 9: MigrateStats only return progress when monitor thread is alive, Line 10: When calling MigrateStats after the thread is dead we get NPE. Line 11: (when calling getMigrationStatus verb) Line 6: Line 7: Getting migration statistics NPE Line 8: Line 9: MigrateStats only return progress when monitor thread is alive, Line 10: When calling MigrateStats after the thread is dead we get NPE. s/NPE/KeyError Line 11: (when calling getMigrationStatus verb) Line 12: Line 13: Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 -- To view, visit https://gerrit.ovirt.org/40657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9277b70432d1d9ecc3c39ee7deabbbd89d179715 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
