As I extended the AbstractSearchTool to create my personal search tool, from my experience I suggest two improvement on it:
1. Change of protected List executeQuery(Object criteria) method.
This method should throw at least a generic Exception in order to let its concrete implementation to do it:
protected List executeQuery(Object criteria) throws Exception
otherwise there are difficulties to handle error conditions.
E.g.
protected List executeQuery(Object criteria) {
try {
// something throws an exception!
} catch (Exception ex) {
// what I do here?
ex.printStackTrace();
return null;
}
return something;
}2. The standard reset() and setCriteria(Object) methods should remove any previous cached (stored) results.
This is just a suggestion but I think the semantic of the methods suggest it.
Gianpiero
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
