[ http://issues.apache.org/jira/browse/VELOCITY-375?page=comments#action_12329911 ]
Nathan Bubna commented on VELOCITY-375: --------------------------------------- No, it's not a "let's roll our own" reflex that triggers this. Adding dependencies is adding complexity (a negative). I don't think an empty string test is worth that cost. As for commons-lang already being a dependency... well, i was already pretty hesitant about that too. only one tool uses it, so it is currently only a runtime dependency if you want to use that tool. adding a compile time dependency for developers is less an issue to me than adding a runtime dependency for users. i'm not going to start accepting use of it in the core classes (making it a runtime dependency for all VelocityView and VelocityStruts users) for something as piddly as an empty string test. :) anyway, i've committed most of the changes (some more in spirit than exact code :), and i'm quite happy with them. are you satisfied with things? let me know if i missed anything key in my tweaks, k? and again, many thanks! > bad errors description > ---------------------- > > Key: VELOCITY-375 > URL: http://issues.apache.org/jira/browse/VELOCITY-375 > Project: Velocity > Type: Improvement > Components: Tools > Versions: 1.1 > Environment: Operating System: All > Platform: All > Reporter: Stepan Koltsov > Priority: Minor > Fix For: Tools-1.2 > Attachments: velocity-tools.patch > > Hello, > I've created toolbox.xml like this: > <toolbox><tool/></toolbox> > (yes, empty <tool/> tag). I got exception > java.lang.NullPointerException > org.apache.velocity.tools.view.ViewToolInfo.getInstance(ViewToolInfo.java:115) > org.apache.velocity.tools.view.servlet.ServletToolboxManager.getToolboxContext(ServletToolboxManager.java:354) > org.springframework.web.servlet.view.velocity.VelocityToolboxView.createVelocityContext(VelocityToolboxView.java:106) > ... > Yes, I know, it's my fault, but I think that errors in toolbox.xml should be > 1. Not fatal; > 2. Should be better explained. > I used velocity-tools-1.1. > And also I have a request -- could you please compile velocity-tools with > debugging info? I had to compile velocity-tools by myself to find error. (I > did > this before I've looked at my toolbox.xml :-) > Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
