Hi Llewllyn,
I'm a bit confused. The patch that you are submitting - does it solve the
issue in Velocity-381? If so, please attach to that issue.
Does the patch solve a different problem? Then create a new issue in JIRA,
describe the problem, attach the test, and attach the solution.
I'm eager to review, comment on, (and if they are ready) apply your patches,
but for ease of processing it's best they go through JIRA. (discussion can
be on the dev list or on the JIRA issue). Let me know if you've any
difficulties logging on or using the system.
Thanks again,
WILL
----- Original Message -----
From: "Llewellyn Falco" <[EMAIL PROTECTED]>
To: "Velocity Developers List" <[email protected]>
Sent: Thursday, September 22, 2005 9:14 PM
Subject: Re: Patch
ok,
you can reproduce all the bug by running the attached tests without the
patches
(as is the point of unit tests)
The patches fix them, most of them are in the order of 1 line, so
easier to see the code rather than explain.
the only issue i saw that related was.
velocity-381
again each test is pretty straight forward about what it is testing.
llewellyn.
----- Original Message -----
From: "Will Glass-Husain" <[EMAIL PROTECTED]>
To: "Velocity Developers List" <[email protected]>;
"Llewellyn Falco" <[EMAIL PROTECTED]>
Sent: Thursday, September 22, 2005 10:29 AM
Subject: Re: Patch
Can you please create a JIRA issue then?
Please list exactly the problem you were experiencing, including how to
reproduce it. Then attach the patch and state how it solves the problem.
Really appreciate your contribution - I don't mean to throw up
unnecessary obstacles. But it makes a big difference in ease of tracking
to have every change tracked and submitted through our issue tracker.
Among other benefits, it documents the change for those who experience
the same bug in an earlier version, and it provides a place for other
developers (e.g. me) to ask questions and offer suggestions for improving
the specific patch. (and the list serv does not always include all
attached files).
Thanks again, WILL
----- Original Message -----
From: "Llewellyn Falco" <[EMAIL PROTECTED]>
To: "Velocity Developers List" <[email protected]>
Sent: Thursday, September 22, 2005 10:11 AM
Subject: Re: Patch
I don't know if there are any jira issue's involved.
It solves the issues of i was experiencing of..
null not being able to pass to uberspect to resolve, as is indecated by
the uberspect implementation and api.
info not being correctly created for a failure in a method call.
if an object is not null, but the toString returns null the silent
failed.
the ant tests passed.
Llewellyn.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
