On Sun, 25 Sep 2005, [EMAIL PROTECTED] wrote: > Author: wglass > Date: Sun Sep 25 00:03:09 2005 > New Revision: 291378 > > URL: http://svn.apache.org/viewcvs?rev=291378&view=rev > Log: > pass template info to uberspector for methods and properties ... > --- > jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java > (original) > +++ > jakarta/velocity/core/trunk/src/java/org/apache/velocity/util/introspection/UberspectImpl.java > Sun Sep 25 00:03:09 2005 > @@ -49,7 +49,7 @@ > /** > * the default Velocity introspector > */ > - private static Introspector introspector; > + protected static Introspector introspector; This is an interface change not mentioned in the log message.
> /** > * init - does nothing - we need to have setRuntimeLogger > @@ -170,7 +170,7 @@ > identifier); > } > > - return (executor != null) ? new VelGetterImpl(executor) : null; > + return (executor.isAlive()) ? new VelGetterImpl(executor) : null; > } This is a semantic change not mentioned in the log message. Might not sub-classes of the previous UberspectImpl not have passed null to this method? I'd keep the null check around. Nice unit tests! - Dan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
